[PATCH] revset: changed spanset implementation to take hidden revisions into account

Matt Mackall mpm at selenic.com
Fri Feb 14 11:36:44 CST 2014


On Fri, 2014-02-14 at 08:49 -0800, Lucas Moscovicz wrote:
>      def __iter__(self):
>          if self._start <= self._end:
>              for r in xrange(self._start, self._end):
> -                yield r
> +                if not self._hidden(r):
> +                    yield r
>          else:
>              for r in xrange(self._start, self._end, -1):
> -                yield r
> +                if not self._hidden(r):
> +                    yield r

How can you fix this so that it minimizes a) expensive name lookups and
b) expensive function calls when the hidden set is empty?


-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list