[PATCH V2] serve: No 'listening at' line when port specified (issue 3976)

Anurag Goel anurag.dsps at gmail.com
Wed Feb 19 14:31:16 CST 2014


# HG changeset patch
# User anuraggoel <anurag.dsps at gmail.com>
# Date 1392841762 -19800
#      Thu Feb 20 01:59:22 2014 +0530
# Node ID 03f3e641e777d7abd214693a821774d588ec1c36
# Parent  0e2877f8605dcaf4fdf2ab7e0046f1f6f80161dd
serve: No 'listening at' line when port specified (issue 3976)

When port is specified in "hg serve" command,then there is no listening.
This problem arise when ui.verbose is not configured which simply return the function value in mid-way.
I think,there is no use of "ui.verbose" statement, so i just cut it out.
Now it gives message to the user "listening at port some number".
I run the test suite.Its working fine except that new line when port is specified.
We need to add one line in test suite wherever port is specified explicitly.

diff -r 0e2877f8605d -r 03f3e641e777 mercurial/commands.py
--- a/mercurial/commands.py	Sat Feb 15 22:09:32 2014 -0600
+++ b/mercurial/commands.py	Thu Feb 20 01:59:22 2014 +0530
@@ -5116,9 +5116,6 @@
         util.setsignalhandler()
         self.httpd = hgweb_server.create_server(self.ui, self.app)
 
-        if self.opts['port'] and not self.ui.verbose:
-            return
-
         if self.httpd.prefix:
             prefix = self.httpd.prefix.strip('/') + '/'
         else:


More information about the Mercurial-devel mailing list