[PATCH V2] pull: close peer repo on completion (issue2797)

Siddharth Agarwal sid0 at fb.com
Tue Feb 25 01:38:48 CST 2014


On 02/24/2014 11:01 PM, Piotr Klecha wrote:
>
> Perhaps never, but since my knowledge of Mercurial is fairly limited, 
> I wanted to make this fix as safe as possible. If you could confirm 
> this is actually unnecessary, I will gladly remove the redundant 
> condition. 

The surrounding code assumes other is not None, so it's very likely 
other being None is a programming error and should not be explicitly 
detected. I definitely think it's unnecessary.

Can you add a test for this? Seems this has user-visible effects so it 
should be fairly easy to add one.


More information about the Mercurial-devel mailing list