[PATCH 2 of 4] revset: added filter method to revset classes

Matt Mackall mpm at selenic.com
Thu Feb 27 16:22:37 CST 2014


On Thu, 2014-02-27 at 14:12 -0800, Lucas Moscovicz wrote:
> # HG changeset patch
> # User Lucas Moscovicz <lmoscovicz at fb.com>
> # Date 1391735891 28800
> #      Thu Feb 06 17:18:11 2014 -0800
> # Node ID b6c85775ed674469fa9b5a5bc66588bed6283dcb
> # Parent  730d872f70ae8b6d7b509cc31c6f85f02c1a1186
> revset: added filter method to revset classes

> +        if self._start <= self._end:
> +            return orderedlazyset(self, l, 'asc')

As I mentioned last time around, these strings indicating direction are
really ugly. Use an int like 1 or -1 or a bool (eg ascending=True) or
basically anything but a string, please.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list