[PATCH 0 of 6 ] better handling when a rule in check-code.py matches wrong

Simon Heimberg simohe at besonet.ch
Tue Jan 7 15:31:16 CST 2014


Patch 1 ignores one check-code match instead of ignoring the entire file.

Patch 2 is a simpler alternative to a patch series I sent earlyer [1].
Instead of more complicated matching for no-check-code, simply print out when this pragma is used. The exceptions must be listed in test-check-code-hg.t, 5 files currently.

Patches 3 to 5 further improve the handling with wrong matches. Good stiles are propagated and used in
later patches. The pragma check-code-ignore is removed. It was only used once ever (removed in patch 3). The reasons are explained in patch 5.

Patch 6 shows when a matching pattern is ignored when debugging. This may be interesting now because 
ignore patterns are more common.

(Additional tought: maybe no-check-code is a bad term and should be to changed no-check-this-file.)


[1]: http://www.selenic.com/pipermail/mercurial-devel/2013-November/054628.html



More information about the Mercurial-devel mailing list