[PATCH 03 of 10] rebase: improve error message for empty --source set

[Pierre-Yves David]

On Mon, Jan 13, 2014 at 02:43:00PM +0100, Mads Kiilerich wrote:
> On 01/13/2014 08:10 AM, Pierre-Yves David wrote:
> >On Sun, Jan 12, 2014 at 05:08:01PM +0100, Mads Kiilerich wrote:
> >># HG changeset patch
> >># User Mads Kiilerich <madski at unity3d.com>
> >># Date 1384730518 18000
> >>#      Sun Nov 17 18:21:58 2013 -0500
> >># Node ID ef40ccf4914c597e32885227dde08abe40e41ad5
> >># Parent  d4c3a8ae89b0e2bf1e8a0bebb3fd6ba49ad1ac62
> >>rebase: improve error message for empty --source set
> >This series is pure gold^W^W^Wlooks good to me up to this revision (included).
> >
> >I've some feedback on other changeset.
> >
> >Note that using ui.status for error message sounds wrong, but the previous code
> >was doing it before.
> 
> I agree but didn't try to change the existing convention. Some of
> the failures should probably be aborts ... and the remaining ones
> should be "I did what you said, but note that it was a NOP" which is
> fine as ui.status. A NOP should probably end up as an abort for "hg
> rebase" but not for "hg pull --rebase".

I was just noticing it while reviewing that. I agree this is out of this series scope.

-- 
Pierre-Yves
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20140113/8d152141/attachment.pgp>