[PATCH 1 of 2 V2] changectx: increase perf of walk function

Mads Kiilerich mads at kiilerich.com
Wed Jan 15 08:42:42 CST 2014


On 01/15/2014 08:07 AM, Siddharth Agarwal wrote:
> On 01/14/2014 06:00 PM, Durham Goode wrote:
>> I originally did that, but largefiles abuses match by setting it's own
>> function to match.matchfn and building some state for every matched file
>> name. So I still need to call match on hits.
>
> In that case, does that need to be accounted for in patch 2 as well?
>
> (Grr, largefiles...)

Indeed. Especially with the .hglf prefix and in combination with the 
different handling of matching and unmatching patterns in different places.

The least insane way to improve that seems to be to get rid of the .hglf 
prefix - especially in the layers where matchers are used.

/Mads


More information about the Mercurial-devel mailing list