[PATCH 1 of 2 V2] changectx: increase perf of walk function

Durham Goode durham at fb.com
Thu Jan 16 13:45:44 CST 2014


On 1/15/14 10:51 AM, "Durham Goode" <durham at fb.com> wrote:

>On 1/14/14 11:07 PM, "Siddharth Agarwal" <sid0 at fb.com> wrote:
>
>>On 01/14/2014 06:00 PM, Durham Goode wrote:
>>> I originally did that, but largefiles abuses match by setting it's own
>>> function to match.matchfn and building some state for every matched
>>>file
>>> name. So I still need to call match on hits.
>>
>>In that case, does that need to be accounted for in patch 2 as well?
>>
>>(Grr, largefiles...)
>>
>
>It's not necessary in patch 2 because largefiles does not call the
>original cat function.  Even if it did, the match object is not passed in,
>so an extension has no way of messing the functions on the match object
>that's inside the original cat function.

If no one else has issues, this patch series is ready for queueing.



More information about the Mercurial-devel mailing list