[PATCH 2 of 4] subrepo: remove unnecessary else clause in hgsubrepo._get

Angel Ezquerra angel.ezquerra at gmail.com
Thu Jan 16 15:19:14 CST 2014


> From: Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> Date: Wed, Jan 15, 2014 at 4:03 PM
> Subject: Re: [PATCH 2 of 4] subrepo: remove unnecessary else clause in
> hgsubrepo._get
> To: Angel Ezquerra <angel.ezquerra at gmail.com>
>
>
> On 11/25/2013 12:46 PM, Angel Ezquerra wrote:
>>
>> # HG changeset patch
>> # User Angel Ezquerra <angel.ezquerra at gmail.com>
>> # Date 1385255580 -3600
>> #      Sun Nov 24 02:13:00 2013 +0100
>> # Node ID 15941436e0ab88dee0f5321f737bcf4bc9774fce
>> # Parent  adb3d2a8dfd8bb1c6531225ef84be55f082bac0f
>> subrepo: remove unnecessary else clause in hgsubrepo._get
>>
>> This revision has no behaviour change. It simply removes an unnecessary else
>> that follows an if / return block. The change looks big because a big chunk of
>> code has been unindented one level.
>
>
> I quite love the idea.
>
> Not that you could ship a white space ignorant version of your diff
> too. Not sure what I prefer.

Umm, I'm not quite sure what you mean by that... what is a white space
ignorant version of a diff?

Cheers,

Angel


More information about the Mercurial-devel mailing list