[PATCH 1 of 7] match: if the repo root is a root, that is the only root we need

Matt Mackall mpm at selenic.com
Mon Jan 20 17:37:23 CST 2014


On Thu, 2014-01-16 at 02:18 +0100, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski at unity3d.com>
> # Date 1380816081 -7200
> #      Thu Oct 03 18:01:21 2013 +0200
> # Node ID 7a74b5ba8e5e663786774fe84ec4ecca0207a9c5
> # Parent  47d0843647d1e32f6af4482867327cec5db11a1f
> match: if the repo root is a root, that is the only root we need
> 
> It will change what ends up in .files() and what is .exact(), in a way that is
> more correct and efficient than before.

What was it doing before, how was it incorrect, and what is it doing
now? You have this info at your fingertips, I have to acquire it by
expensive, error-prone reverse-engineering of your patch, so please
include it in the description.

>    $ hg debugwalk 'relglob:Procyonidae/**' fennel
> -  f  fennel                          fennel                          exact
> +  f  fennel                          fennel

If 'fennel' is not an exact match here now, then I'm pretty sure this
patch must be wrong. The purpose of exact() is to distinguish between
things that match command line args exactly and things that simply match
patterns.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list