[PATCH] run-tests: test result shows when a failed test could not start a server

[Simon Heimberg]

Simon Heimberg <simohe <at> besonet.ch> writes:
> 
> # HG changeset patch
> # User Simon Heimberg <simohe <at> besonet.ch>
> # Date 1385413246 -3600
> # Node ID afdcb3c8d7aae39b02ea208c180e36a2a6602bf0
> # Parent  e2068d5d4289fe61f2e5739d62d92fa3c0c2f285
> run-tests: test result shows when a failed test could not start a server
> 
> Failing to start a server happens regularly, at least on windows buildbot.
> Such a failure often has nothing to do with the test, but with the 
environment.
> But half the test output can change because some data is missing. 
Therefore this
> is worth an extended error message.
> 
> Detect the server failure in the diff output because it is most reliable
> there. Checking the output only does not show if the server failure was
> expected.
> 
>  Old failure message when server start failed:
> Failed test-serve.t: output changed
> 
>  New message:
> Failed test-serve.t: serve failed and output changed
> 
> diff -r e2068d5d4289 -r afdcb3c8d7aa tests/run-tests.py
> --- a/tests/run-tests.py	Son Nov 17 20:15:28 2013 +0100
> +++ b/tests/run-tests.py	Mon Nov 25 22:00:46 2013 +0100
<snip>

This patch would help to read the test results of buildbot more easily (for 
windows tests). The problem of a failing server start would directly be 
visible in the warning log [1] and in the rss feed [2]. So more important 
failures would not be hidden in the mass anymore.


[1] warnings: 
http://hgbuildbot.kublai.com/builders/Windows%202008%20R2%20hg%20tests/build
s/76/steps/run-tests.py%20%28python2.6%29/logs/warnings%20%2821%29
[2] rss: http://hgbuildbot.kublai.com/rss