[PATCH STABLE (white-space-fixed)] clone: do not turn hidden changeset public on publishing clone (issue3935)

[Pierre-Yves David]

On 01/30/2014 01:52 PM, pierre-yves.david at ens-lyon.org wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> # Date 1391111558 28800
> #      Thu Jan 30 11:52:38 2014 -0800
> # Branch stable
> # Node ID 4cd3a83faa488d6aef4fde615461e6307fa124de
> # Parent  427d672c0e4e07642d2400a28946cefde11e04ff
> clone: do not turn hidden changeset public on publishing clone (issue3935)
>
> Before this changeset local clone of a repo with hidden changeset would include
> then in the clone (why not) and turn them public (plain wrong). This happened
> because the copy clone publish by dropping the phaseroot file entirely making
> everything in the repo public (and therefore immune to obsolescence marker).
>
> This changeset takes the simplest fix, we deny the copy clone in the case of hidden
> changeset falling back to pull clone that will exclude them from the clone and
> therefore not turning them public.
>
> A smarter version of copy clone could be done, but I prefer to go for the
> simplest solution first.

Patch already pushed, but posting a fixed vesion for good measure.