[PATCH] util: set the hidden attribute on .hg/ during creation on windows (issue4178)

Augie Fackler raf at durin42.com
Fri Mar 7 15:10:59 CST 2014


On Mar 7, 2014, at 2:43 PM, Matt Mackall <mpm at selenic.com> wrote:

> On Fri, 2014-02-21 at 16:31 +0000, Ed Morley wrote:
>> # HG changeset patch
>> # User Ed Morley <emorley at mozilla.com>
>> # Date 1392999130 0
>> #      Fri Feb 21 16:12:10 2014 +0000
>> # Node ID e74d0479759cbea6edb632273345d55f96374d70
>> # Parent  0e2877f8605dcaf4fdf2ab7e0046f1f6f80161dd
>> util: set the hidden attribute on .hg/ during creation on windows (issue4178)
>> 
>> Windows has no concept of dotfiles/directories being hidden - instead, it
>> requires that a file-is-hidden attribute be set. This patch adds an optional
>> parameter to util.makedir/util.makedirs - which is used to set the hidden
>> attribute when the .hg directory is created on Windows.
>> 
>> This has the advantage that both the OS filesystem search & also editors
>> grepping repositories can easily exclude the .hg directory, without needing to
>> exclude it manually every time.
> 
> I think 9 years in, this is probably too surprising a change. We could
> have done this out of the gate.. but no one cared enough to even mention
> it for the first 7 years.

OOC, why? It's already hidden on all other platforms, and that strikes me as a Good Thing. Why do we want to leave windows out in the cold here?

> 
> -- 
> Mathematics is the supreme nostalgia of our time.
> 
> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20140307/9c3c76e0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20140307/9c3c76e0/attachment.pgp>


More information about the Mercurial-devel mailing list