[PATCH 4 of 5 V2] histedit: add execute function (issue4036)

[Augie Fackler]

On Mar 8, 2014, at 5:26 AM, Martin Geisler <martin at geisler.net> wrote:

> Olle <olle.lundberg at gmail.com> writes:
> 
>> On Thu, Mar 6, 2014 at 8:41 PM, Augie Fackler <raf at durin42.com> wrote:
>> 
>>> 
>>> On Mar 6, 2014, at 1:52 PM, Olle <olle.lundberg at gmail.com> wrote:
>>> 
>>> It seems reasonable, it might be confusing for git refugees though. Not
>>> that we try to cater everything for them. Just a heads up. I'm up for
>>> changing it, if filterrevs are prefered. But then we'll get two commands
>>> (histedit and filterrecs) doing more or less the same thing, history
>>> editing, except one is automatic. Don't know how if that will be confusing.
>>> 
>>> 
>>> Place git out of your mind for the moment.
>>> 
>>> The way I'm thinking about this is that there's interactive history
>>> rearrangement and editing (histedit) and pseudo-automated reformatting of
>>> commits without reordering (filter revs). Does that seem like a reasonable
>>> split?
>>> 
>> 
>> Yeah, I'd like to place git as far as way as possible. And I can very much
>> agree that it makes sense to split them up. The use case would then become:
>> 
>> hg histedit deadbeef
>> and then
>> 
>> hg filterrevs deadbeef:cafebabe "everything else as a command?"
>> or perhaps:
>> hg filterrevs deadbeef:cafebabe --cmd "cool command here"
> 
> I will propose
> 
>  hg filterrevs deadbeef:cafebabe everything else as a command

I think I like it. Might be worth running with this as an out-of-tree extension for ~one release cycle to make sure it's "right" before we put it in core?

> 
> If the command takes flags, one would use
> 
>  hg filterrevs deadbeef:cafebabe -- everything else as a command
> 
> to tell Mercurial where the positional arguments begin (this is the
> standard way to indicate that, compare with, e.g., 'rm -- --foo').
> 
> Brief testing seems to indicate that this doesn't clash with the early
> option parsing, that is, 'hg stat -- -R no-such-file' correctly tries to
> show status for the two files '-R' and 'no-such-file'.
> 
> -- 
> Martin Geisler
> 
> http://google.com/+MartinGeisler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20140308/bfb36820/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20140308/bfb36820/attachment.pgp>