[PATCH] util: set the hidden attribute on .hg/ during creation on windows (issue4178)

[Gregory Szorc]

On 3/9/2014 1:49 PM, Matt Mackall wrote:
> On Sat, 2014-03-08 at 22:51 +0100, Adrian Buehlmann wrote:
>> On 2014-03-08 22:05, Matt Mackall wrote:
>>> On Sat, 2014-03-08 at 01:15 +0100, Adrian Buehlmann wrote:
>>>> Perhaps a compromise could be made by setting the hidden flag on
>>>> .hg/store on new repositories...
>>>
>>> How is this not going to confuse/surprise a veteran hg user?
>>
>> I'd expect almost no one would even notice it, as users generally have
>> no reason to navigate into .hg/store with tools like explorer.
> 
> Oh, I see. I missed the 'store' part and only caught the 'new
> repositories' part. Sorry, yes, that is different.
> 
> What happens when you copy a folder^H^H^H^H^H^Hdirectory in Explorer
> that contains a hidden directory? We don't want that to break either.

The hidden directory is copied.

I support the change. Even though it is backwards incompatible behavior,
I think setting the hidden attribute is the right thing to do. Setting
the hidden attribute conveys the message "don't be mucking around in
here." Users shouldn't be directly editing any files in .hg except for
hgrc (are there any others?) and making the directory hidden will help
reinforce that.

I'd like to think the upcoming 3.0 release is a good opportunity to make
changes like this.