[PATCH] util: set the hidden attribute on .hg/ during creation on windows (issue4178)

Matt Mackall mpm at selenic.com
Mon Mar 10 11:03:15 CDT 2014


On Sun, 2014-03-09 at 23:36 -0700, Gregory Szorc wrote:
> On 3/9/2014 1:49 PM, Matt Mackall wrote:
> > On Sat, 2014-03-08 at 22:51 +0100, Adrian Buehlmann wrote:
> >> On 2014-03-08 22:05, Matt Mackall wrote:
> >>> On Sat, 2014-03-08 at 01:15 +0100, Adrian Buehlmann wrote:
> >>>> Perhaps a compromise could be made by setting the hidden flag on
> >>>> .hg/store on new repositories...
> >>>
> >>> How is this not going to confuse/surprise a veteran hg user?
> >>
> >> I'd expect almost no one would even notice it, as users generally have
> >> no reason to navigate into .hg/store with tools like explorer.
> > 
> > Oh, I see. I missed the 'store' part and only caught the 'new
> > repositories' part. Sorry, yes, that is different.
> > 
> > What happens when you copy a folder^H^H^H^H^H^Hdirectory in Explorer
> > that contains a hidden directory? We don't want that to break either.
> 
> The hidden directory is copied.

Ok, how about xcopy? Since that has a /h flag, I suspect the answer is
no.

We can only guess at the thousands of habits our users may have formed
that might conflict with this idea in a surprising way... so this really
warrants some thorough defensive thinking beforehand.

(Folks, if you're reading 'surprise' here and not hearing 'tragic data
loss' in your head, you may be missing why this is a big deal.)

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list