[PATCH 07 of 18 helps-py3] hgwebdir_mod: move from dict() construction to {} literals
Augie Fackler
raf at durin42.com
Wed Mar 12 12:40:41 CDT 2014
# HG changeset patch
# User Augie Fackler <raf at durin42.com>
# Date 1394644537 14400
# Wed Mar 12 13:15:37 2014 -0400
# Node ID 0e757575aef5e24f0723ad06cd5742e0c603865f
# Parent 89b2336e5ccfdbdc2282b9bfd54127f54074ae3e
hgwebdir_mod: move from dict() construction to {} literals
The latter are both faster and more consistent across Python 2 and 3.
diff --git a/mercurial/hgweb/hgwebdir_mod.py b/mercurial/hgweb/hgwebdir_mod.py
--- a/mercurial/hgweb/hgwebdir_mod.py
+++ b/mercurial/hgweb/hgwebdir_mod.py
@@ -308,17 +308,17 @@
# add '/' to the name to make it obvious that
# the entry is a directory, not a regular repository
- row = dict(contact="",
- contact_sort="",
- name=name + '/',
- name_sort=name,
- url=url,
- description="",
- description_sort="",
- lastchange=d,
- lastchange_sort=d[1]-d[0],
- archives=[],
- isdirectory=True)
+ row = {'contact': "",
+ 'contact_sort': "",
+ 'name': name + '/',
+ 'name_sort': name,
+ 'url': url,
+ 'description': "",
+ 'description_sort': "",
+ 'lastchange': d,
+ 'lastchange_sort': d[1]-d[0],
+ 'archives': [],
+ 'isdirectory': True}
seendirs.add(name)
yield row
@@ -356,17 +356,18 @@
contact = get_contact(get)
description = get("web", "description", "")
name = get("web", "name", name)
- row = dict(contact=contact or "unknown",
- contact_sort=contact.upper() or "unknown",
- name=name,
- name_sort=name,
- url=url,
- description=description or "unknown",
- description_sort=description.upper() or "unknown",
- lastchange=d,
- lastchange_sort=d[1]-d[0],
- archives=archivelist(u, "tip", url),
- isdirectory=None)
+ row = {'contact': contact or "unknown",
+ 'contact_sort': contact.upper() or "unknown",
+ 'name': name,
+ 'name_sort': name,
+ 'url': url,
+ 'description': description or "unknown",
+ 'description_sort': description.upper() or "unknown",
+ 'lastchange': d,
+ 'lastchange_sort': d[1]-d[0],
+ 'archives': archivelist(u, "tip", url),
+ 'isdirectory': None,
+ }
seenrepos.add(name)
yield row
More information about the Mercurial-devel
mailing list