[PATCH RESEND] histedit: select the lowest rev when looking for a root in a revset
David Soria Parra
davidsp at fb.com
Tue Mar 18 11:06:42 CDT 2014
On 3/17/14, 5:21 PM, "Siddharth Agarwal" <sid0 at fb.com> wrote:
>On 03/17/2014 05:13 PM, Siddharth Agarwal wrote:
>> On 03/17/2014 10:10 AM, David Soria Parra wrote:
>>> + root = 'min(%s)' % revs[0]
>>> root = scmutil.revsingle(repo, root).node()
>>
>> Can you actually interpolate revs[0] like that?
>
>I meant in terms of needing to escape revs[0], etc. You might need to
>use repo.revs() here. I don't know how you'd resolve backwards
>compatibility: scmutil.revrange(), which revsingle() calls, has the
>notion of old-style queries.
rev single uses scmutil.revrange which we usually use to do parse the
non-escaped revisions, so therefore my understanding is that it¹s fine to
do that
this way.
More information about the Mercurial-devel
mailing list