[PATCH STABLE] hg: use "os.path.join()" to join path components which may be empty (issue4203)

David Soria Parra dsp at experimentalworks.net
Tue Mar 25 11:54:10 CDT 2014


FUJIWARA Katsunori <foozy at lares.dti.ne.jp> writes:

> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1395743657 -32400
> #      Tue Mar 25 19:34:17 2014 +0900
> # Branch stable
> # Node ID 2d982084f093a9d2bc0f9927ffc28a85884b1563
> # Parent  e5641536e4d509b2dc5fab783344f86ea61b17c2
> hg: use "os.path.join()" to join path components which may be empty (issue4203)
>
> Changset 2d0ab571b822 rewriting "hg.copystore()" with vfs uses
> 'dstbase + "/lock"' instead of "os.path.join()", because target files
> given from "store.copyfiles()" already uses "/" as path separator
>
> But in the repository using revlog format 0, "dstbase" becomes empty
> ("data" directory is located under ".hg" directly), and 'dstbase +
> "/lock"' is treated as "/lock": in almost all cases, write access to
> "/lock" causes "permission denied".
>
> This patch uses "os.path.join()" to join path components which may be
> empty in "hg.copystore()".

Looks good to me. Thank you.
Queued to http://hg.netv6.net/hg-fb-reviewers.


More information about the Mercurial-devel mailing list