[PATCH 2 of 7] clone: put streaming clones in a transaction

[Matt Mackall]

On Mon, 2014-03-24 at 19:33 -0700, Durham Goode wrote:
> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1395700700 25200
> #      Mon Mar 24 15:38:20 2014 -0700
> # Node ID 08595987c5b0e8af5aa8fec4debd7260f5a79e8f
> # Parent  ab3be74e8022c31b7c95975fb09b3602ed7775d8
> clone: put streaming clones in a transaction
> 
> Streaming clones were writing to files outside of a transaction. Soon the
> fncache will be written at transaction close time, so we need streaming clones
> to be in a transaction.

Hmm. But you're not adding the streamed files to the transaction? 

> +            # Writing straight to files circumvented the inmemory caches
> +            self.invalidate()

Isn't there a lock held here that will invalidate() on release?

-- 
Mathematics is the supreme nostalgia of our time.