[PATCH 8 of 9 V3] repoview: copy blocker code from computehidden

[Pierre-Yves David]

On 03/28/2014 03:06 PM, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley <sean.michael.farley at gmail.com>
> # Date 1396028401 18000
> #      Fri Mar 28 12:40:01 2014 -0500
> # Node ID e2f87be23b410518a1d3d63931c976ad05bfd0a5
> # Parent  ee7162b508580c2b60db9b7d5e4d71c2818a70d7
> repoview: copy blocker code from computehidden
>
> This is just a code copy of the how hidden blockers are currently computed and
> will be used in an upcoming patch.

Merge this with the previous changeset.


>
> diff --git a/mercurial/repoview.py b/mercurial/repoview.py
> --- a/mercurial/repoview.py
> +++ b/mercurial/repoview.py
> @@ -20,11 +20,27 @@ def hideablerevs(repo):
>
>   def _gethiddenblockers(repo):
>       """Get revisions that will block hidden changesets from being filtered
>
>       This is a standalone function to help extensions to wrap it."""
> -    pass
> +    assert not repo.changelog.filteredrevs

‽‽‽ this sounds very wrong to me. Are you trying to unsure the repo is 
unfiltered? If so, use repo.unfiltered()

You could list the existing blocker somewhere (like the docstring)


-- 
Pierre-Yves