[PATCH 4 of 5 resolve-ux] resolve: print warning when no work performed (issue4208)

Mads Kiilerich mads at kiilerich.com
Sun May 4 15:48:44 CDT 2014


On 05/03/2014 11:27 PM, Gregory Szorc wrote:
> +
> +    if not didwork and pats:
> +        ui.warn(_("no work performed. specified path(s) invalid?\n"))

I think this message will need some bike shedding to be consistent with 
other message. Some thoughts:

* "work" is unclear, better say what you know "patterns did not match 
any files that need resolving" (which however is too long)
* it is better to use one sentence with no period - we seem to often use 
, or ;.
* make it more of a full sentence (or two)
* Mercurial do not try to get the plural s right in messages - just use 
'paths'

/Mads


More information about the Mercurial-devel mailing list