[PATCH STABLE] win32: backout 1a9ebc83a74c

[Pierre-Yves David]

On 05/05/2014 11:56 AM, Steve Borho wrote:
> On Sat, May 3, 2014 at 3:43 AM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>> # HG changeset patch
>> # User Adrian Buehlmann <adrian at cadifra.com>
>> # Date 1399106034 -7200
>> # Branch stable
>> # Node ID b3bceb2a103e9f279f058e7a3bacf272968b6bb6
>> # Parent  d36440d843284ba546858b241da9cc4817811fe5
>> win32: backout 1a9ebc83a74c
>>
>> This appears to cause havoc on TortoiseHg. While 1a9ebc83a74c may be nice to
>> have (as soon as someone can prove it has no unwanted side effects), it is not
>> worth the troubles at this point.
>
> To add some context; the troubles are specifically that files which
> are being "watched" for changes by QFileSystemWatcher() are no longer
> safely updated by util.rename().  So things like updating .hg/hgrc or
> perhaps even the changelog are suddenly dangerous.  We're still not
> completely certain of the exact semantics of the problem so I don't
> know if this patch is mandatory, but we believe it would resolve the
> problem.

Do you have actually example of bugs this changes introduce (I'm curious)