[PATCH 1 of 9] histedit: use "editor" argument of "commit()" instead of explicit "ui.edit()"

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue May 6 19:14:30 CDT 2014



On 05/05/2014 05:33 AM, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1399292800 -32400
> #      Mon May 05 21:26:40 2014 +0900
> # Branch stable
> # Node ID b683de8e06581ebb2a59120b118539a839bcfb06
> # Parent  cadad384c97c7956c98f3c9b92d8cc40fa16d93b
> histedit: use "editor" argument of "commit()" instead of explicit "ui.edit()"

After a long hesitation I ended up queuing this series to the 
clowncopter repo.

I uncomfortable with multiple aspect of this series and I'm half 
thinking that passing editor to memctx.__init__ is a layer violation 
(but also half thinking it make perfect sense).

However I finally realized that nothing in this series can be worth that 
the widespread new._test = editor(…) idioms.

Thanks alot for the cleanup!

Consider keep digging further in this direction.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list