[PATCH 005 of 179 tests-refactor] run-tests: move createhgrc() call into Test.run()

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed May 7 15:39:35 CDT 2014



On 05/02/2014 11:37 AM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1397938309 25200
> #      Sat Apr 19 13:11:49 2014 -0700
> # Branch stable
> # Node ID 27f7274d1694f92571e68c63696cead7658271eb
> # Parent  71520e4115ab64e38cc872ec04044f37c747ffcf
> run-tests: move createhgrc() call into Test.run()
>
> createhgrc() is an implementation detail of how tests are run. It makes
> sense to move it into Test.run().
>
> Note that this will cause the test execution time to include the
> creation of hgrc. The author does not believe this is a significant
> change worth worrying about.

including hgrc time does not seems a real issue. Do you, later in your 
series make a distinction between test setup and actual test run?

is methods needs a docstring.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list