[PATCH 1 of 8] merge: improve debug messages for bid merge

Mads Kiilerich mads at kiilerich.com
Thu May 8 08:29:18 CDT 2014


On 05/07/2014 11:00 PM, Pierre-Yves David wrote:
>
>
> On 05/01/2014 04:42 PM, Mads Kiilerich wrote:
>> # HG changeset patch
>> # User Mads Kiilerich <madski at unity3d.com>
>> # Date 1398125364 -7200
>> #      Tue Apr 22 02:09:24 2014 +0200
>> # Branch stable
>> # Node ID 7d8e70a9006e34e2ec129f2972ce41962e35ccd9
>> # Parent  cadad384c97c7956c98f3c9b92d8cc40fa16d93b
>> merge: improve debug messages for bid merge
>
> review: improve commit for reviewer.

What do that sentence mean ... if it is a sentence and not some kind of 
automated test comment?

> Specifically, include "before" and "after" output + rational for the 
> change would be nice.

In principle I agree. In this case when the change is so simple and you 
know it is code I just introduced and it is made clear that it just is a 
debug message, it would be absurd and waste of time to go that much into 
details.

/Mads


More information about the Mercurial-devel mailing list