[PATCH 5 of 8] merge: separate worker functions for batch remove and batch get

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu May 8 14:57:08 CDT 2014



On 05/08/2014 04:39 AM, Mads Kiilerich wrote:
> On 05/07/2014 11:09 PM, Pierre-Yves David wrote:
>>
>>
>> On 05/01/2014 04:42 PM, Mads Kiilerich wrote:
>>> # HG changeset patch
>>> # User Mads Kiilerich <madski at unity3d.com>
>>> # Date 1398985754 -7200
>>> #      Fri May 02 01:09:14 2014 +0200
>>> # Branch stable
>>> # Node ID 9d786e6be4319bf31467eb715fb432c68ccd4507
>>> # Parent  feac4ee682bea8ebb19ead775bdb9ef413da8e3e
>>> merge: separate worker functions for batch remove and batch get
>>
>>
>> Why is this necessary//useful?
>
> The old code had one function that could do 2 different things. First,
> is was called a bunch of times to do one thing. Next, it was called a
> bunch of times to do the other thing. That gave unnecessary complexity
> and a dispatch overhead. Having separate functions is "obviously" better
> than having a function that can do two things, depending on its parameters.
>
> And again: it prepares for the 8th patch.

Please apply update your changeset description with this convincing 
explanation.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list