[PATCH] hgweb: apply websub filter to the changeset description in rss and atom feeds

Steven Brown stevengbrown at gmail.com
Thu May 15 06:45:28 CDT 2014


On 15 May 2014 14:42, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org>
wrote:
>
>
>
> On 05/13/2014 08:07 PM, Steven Brown wrote:
>>
>> On 8 May 2014 04:42, Pierre-Yves David <pierre-yves.david at ens-lyon.org
>> <mailto:pierre-yves.david at ens-lyon.org>> wrote:
>>
>>
>>
>>     On 05/06/2014 11:48 PM, Steven Brown wrote:
>>
>>         # HG changeset patch
>>         # User Steven Brown <StevenGBrown at gmail.com
>>         <mailto:StevenGBrown at gmail.com>>
>>
>>         # Date 1399444707 -28800
>>         #      Wed May 07 14:38:27 2014 +0800
>>         # Node ID 171396ccd63139e6427ec6da2400e8__bda3c803c7
>>         # Parent  0768cda8b5799dc803dc0ee27a832c__d64e05f28a
>>
>>         hgweb: apply websub filter to the changeset description in rss
>>         and atom feeds
>>
>>
>>     Test change makes sense to me. But:
>>
>>     1. Can we have it tested?
>>
>>
>> Yes, although I think that a unified test would have little value.
>> Instead, we could have a check-code rule detect whether the websub
>> filter is applied consistently throughout the templates. I'd be happy to
>> send patches for check-code once this hgweb patch has been accepted.
>
>
> I believe that testing the rss and atom feed would be useful
> (in general)
>
> A check code rules is definitely a good idea.

OK, I'll send a new patch series soon.

>>     2. Should the documentation about websub be updated to mention that?
>>
>>
>> The hgrc documentation already mentions that websub is applied to the
>> revision descriptions. I think there is no need to make special mention
>> of the rss and atom feeds.
>
>
> Ok. No doc update then.
>
>
> --
> Pierre-Yves David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20140515/1d87ca33/attachment.html>


More information about the Mercurial-devel mailing list