[PATCH] update: when deactivating a bookmark, print a message

Matt Mackall mpm at selenic.com
Thu May 15 11:40:49 CDT 2014


On Wed, 2014-05-14 at 12:50 -0700, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1400096995 25200
> #      Wed May 14 12:49:55 2014 -0700
> # Node ID 8ec9ebbd09addc74ae17cc5f2ea13cb4c732a286
> # Parent  883e268cb860c0ea2eb0faa94114e11c3a4a3893
> update: when deactivating a bookmark, print a message
> 
> This helps prevent user confusion when innocent-seeming commands like
> 'hg update -C .' are run.

Ok, your message is:

  marking bookmark c inactive

This is slightly weird to me as "active" is not so much a state of the
bookmark (ie a bit on the bookmark that allows you to mark some set of
bookmarks active/inactive) but a state of a repository (bookmark x | nil
is active). I think I might prefer:

  deactivating bookmark c

Or even:

  leaving bookmark c

..which gives more of a sense of 'why'. We might even want to add
parentheses as well to emphasize that all is normal.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list