[PATCH 02 of 19] basectx: add _manifestmatches method that is a duplicate of mfmatches

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu May 15 17:27:29 CDT 2014



On 05/15/2014 02:16 PM, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley<sean.michael.farley at gmail.com>
> # Date 1398304330 18000
> #      Wed Apr 23 20:52:10 2014 -0500
> # Node ID 4f3d70781a6031841ed191b360b7971af948977f
> # Parent  ac2d57df1c2160e6da43d112b9eadfe688415472
> basectx: add _manifestmatches method that is a duplicate of mfmatches

Whats is `mfmatches`?

Something along the line of:

   basectx: add _manifestmatches method

   This methods is a duplicate that is a duplicate
   of localrepo.mfmatches.

Would be much clearer.

> diff --git a/mercurial/context.py b/mercurial/context.py
> --- a/mercurial/context.py
> +++ b/mercurial/context.py
> @@ -61,10 +61,19 @@ class basectx(object):
>
>       def __iter__(self):
>           for f in sorted(self._manifest):
>               yield f
>
> +    def _manifestmatches(self, match, s):

This methods wants a docstring.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list