[PATCH stable] convert: convert real global tags only - not local tags

Mads Kiilerich mads at kiilerich.com
Thu May 15 19:32:04 CDT 2014


On 05/15/2014 09:16 PM, Pierre-Yves David wrote:
>
>
> On 05/15/2014 12:06 PM, Sean Farley wrote:
>>
>> Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:
>>
>>> On 05/14/2014 04:50 AM, Mads Kiilerich wrote:
>>>> # HG changeset patch
>>>> # User Mads Kiilerich <madski at unity3d.com>
>>>> # Date 1400068180 -7200
>>>> #      Wed May 14 13:49:40 2014 +0200
>>>> # Node ID 6878d40f8a2153885374ba636a3b183a5a369d36
>>>> # Parent  62a2749895e4151f766a4243fa870b1ddd7386d0
>>>> convert: convert real global tags only - not local tags
>>>
>>>
>>> Not sure to understand what this patch is about.

This is about convert and tags, local and global.

>>>
>>> What is the problematic behavior before this patches. 

Convert did not only convert global tags - it also converted local tags.

>>> How does this patches fixes it?

It makes it so that convert only converts global tags - not local tags.

> Sounds requires a description udpate -and- a comment in the code.

It is ridiculous to have to describe the basic functionality of a sub 
system every time a patch touches it.

What comment would you add? "we only consider the tags from taglist 
where the type is global"?

/Mads


More information about the Mercurial-devel mailing list