[PATCH 12 of 22] Makefile: replace platform specific rpm build targets with rpm and rpm-py

[Mads Kiilerich]

On 05/20/2014 06:20 PM, Matt Mackall wrote:
> On Tue, 2014-05-20 at 04:10 +0200, Mads Kiilerich wrote:
>> # HG changeset patch
>> # User Mads Kiilerich <madski at unity3d.com>
>> # Date 1400551681 -7200
>> #      Tue May 20 04:08:01 2014 +0200
>> # Node ID 75c1b9ca3644252245840f7276f8223803805a4e
>> # Parent  b71a9c09bdc9b2a04679a34e0ef0765ffbbbb933
>> Makefile: replace platform specific rpm build targets with rpm and rpm-py
> It's quite intentional that there's a "make fedora" target (regardless
> of how redundant it currently appears). I don't think it's a safe
> assumption that the package contents and build process for Fedora vs
> Centos 6 are constant, and we haven't even brought SuSE or any of the
> other RPM-based distros into the mix.

I agree that there might be differences in some details. Currently there 
is no significant differences.

Most of the difference will be inside the spec file where it usually is 
handled using macros and conditionals. One such difference is in how 
Python 2.4 currently has to be handled slightly different.

I doubt there will be differences where the best abstraction is at the 
Makefile level and exposed as different make targets. I would imagine 
that it would be something that is handled inside rpmbuild or 
dockerbuild, similar to how we now "dispatch" to different docker files.

The current Makefile already have differences between the fedora and the 
centos6 target - I assume that is a "bug". Would you prefer to add yet 
another similar section for centos5 and fedora19 and fedorarawhide?

/Mads