[PATCH 5 of 5] convert: introduce --config convert.hg.full=1 for adding all files, not just changed

[Mads Kiilerich]

On 05/27/2014 03:46 AM, Matt Mackall wrote:
> On Mon, 2014-05-26 at 19:26 +0200, Mads Kiilerich wrote:
>> On 05/26/2014 06:30 PM, Augie Fackler wrote:
>>> On Mon, May 19, 2014 at 10:33:33PM +0200, Mads Kiilerich wrote:
>>>> # HG changeset patch
>>>> # User Mads Kiilerich <madski at unity3d.com>
>>>> # Date 1400530735 -7200
>>>> #      Mon May 19 22:18:55 2014 +0200
>>>> # Node ID fbd0070089aef388ffb4bbae6ac34ff2bc17cd3f
>>>> # Parent  c28cc8a6bd6226f0588365d5ae8e3d8a42cfa063
>>>> convert: introduce --config convert.hg.full=1 for adding all files, not just changed
>>> I'm not sure what this means...
>> It is hard to explain - especially in 80 characters and without making
>> both the default and and this behaviour sound stupid.
>>
>> The option should perhaps also be called something more verbose than
>> just "full".
> Probably something like "checkunmodified". I presume this doesn't
> actually commit new copies of files that are already tracked, right?

It will commit all files, but unmodified files will not create a new 
filelog entry and will thus be noops not creating new copies.

(I tried enabling it everywhere and investigated all the differences it 
gave. Everything (including hashes) stayed the same except where there 
was good reasons it made a difference.)

So it will actually not "check", even though the user experience is that 
it checks for missing files and then (more important) adds them.


It should perhaps also be named to make it clear that it is an option on 
the hg source, not the hg sink.

Anyway, the main point is that it will get all the files back in sync. 
So "convert.hg.syncallfiles" or "convert.hg.reconvertallfiles"?

/Mads