[PATCH 2 of 4] largefiles: remove confusing 'or None' from predicate

Martin von Zweigbergk martinvonz at google.com
Sun Nov 2 15:43:14 CST 2014


# HG changeset patch
# User Martin von Zweigbergk <martinvonz at google.com>
# Date 1414469424 25200
#      Mon Oct 27 21:10:24 2014 -0700
# Branch stable
# Node ID 306755539e7e90d6ab8d5dccd68fc8b07042636a
# Parent  b18b2bba8ab399fa150015d9d64549687d4c7972
largefiles: remove confusing 'or None' from predicate

The match function that is overriden returns a boolean value, so
adding 'or None' is both unnecessary and confusing.

diff --git a/hgext/largefiles/overrides.py b/hgext/largefiles/overrides.py
--- a/hgext/largefiles/overrides.py
+++ b/hgext/largefiles/overrides.py
@@ -35,7 +35,7 @@
         m._fmap = set(m._files)
         m._always = False
         origmatchfn = m.matchfn
-        m.matchfn = lambda f: notlfile(f) and origmatchfn(f) or None
+        m.matchfn = lambda f: notlfile(f) and origmatchfn(f)
         return m
     oldmatch = installmatchfn(overridematch)
 


More information about the Mercurial-devel mailing list