[PATCH 2 of 5] test-revert: don't unnecessarily pipe through 'cat'

[Martin von Zweigbergk]

On Sun Nov 02 2014 at 2:45:40 PM Pierre-Yves David <
pierre-yves.david at ens-lyon.org> wrote:

>
>
> On 11/02/2014 10:19 PM, Martin von Zweigbergk wrote:
> > # HG changeset patch
> > # User Martin von Zweigbergk <martinvonz at google.com>
> > # Date 1413682221 25200
> > #      Sat Oct 18 18:30:21 2014 -0700
> > # Branch stable
> > # Node ID 9439327a222474b6af32ed9f717bfce81f90e53b
> > # Parent  5df55ad6918a76870695dfe855168309bb5da27c
> > test-revert: don't unnecessarily pipe through 'cat'
> >
> > diff --git a/tests/test-revert.t b/tests/test-revert.t
> > --- a/tests/test-revert.t
> > +++ b/tests/test-revert.t
> > @@ -730,7 +730,7 @@
> >
> >   Setup working directory
> >
> > -  $ python ../gen-revert-cases.py wc | cat
> > +  $ python ../gen-revert-cases.py wc
> >     $ hg addremove --similarity 0
> >     removing added_removed
> >     removing added_revert
>
>
> check-code says hi:
>
>     Skipping mercurial/httpclient/socketutil.py it has no-che?k-code
> (glob)
> +  tests/test-revert.t:733:
> +   >   $ python ../gen-revert-cases.py wc
> +   filter wc output
> +  [1]
>

Oops, sorry about that. What's the purpose of it? The check was in the
first version of check-code, so I couldn't find any explanation for it in
the changelog.


> I'm not sure about the 3 others patches. What is wrong with some
> duplicated case? Why is it worth introducing special casing to remove them
> ?
>

I think the file histories are clearer when expressed in terms of the
states rather than transitions, so in the end (after ~7 more patches), e.g.
'modified_untracked-clean' becomes 'content1_content2_untracked_content2'.
The generation script actually becomes a bit simpler at that point. I
suppose a 11-patch series is too long. Do you want to see the end state in
some other form before you decide?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20141102/07c8d7ee/attachment.html>