[PATCH 4 of 4] largefiles: simplify check for lack of path arguments

Martin von Zweigbergk martinvonz at google.com
Mon Nov 3 00:19:52 CST 2014


On Sun Nov 02 2014 at 5:18:46 PM Mads Kiilerich <mads at kiilerich.com> wrote:

> On 11/02/2014 10:43 PM, Martin von Zweigbergk wrote:
> > # HG changeset patch
> > # User Martin von Zweigbergk <martinvonz at google.com>
> > # Date 1414963088 28800
> > #      Sun Nov 02 13:18:08 2014 -0800
> > # Branch stable
> > # Node ID 3df2c5d179ddcd2ff0a1edca410ff2139725e210
> > # Parent  b89ddc59955d4ffc106c8566af52111f7d52f718
> > largefiles: simplify check for lack of path arguments
> >
> > Instead of checking for a partial merge by checking that the matches
> > has no files and no patterns, check that it's not an
> > always-matcher. Except for being shorter, it also catches the rare
> > case of an exact-matcher with no files.
>
> Please add a test case for that.
>

I'm afraid that should have been s/rare/hypothetical/. Such matchers are
sometimes created (mostly by mq, but also in import and revert), but it
seems like the matcher that's passed into localrepo.commit() (the method I
modified in this patch) can not be an exact matcher with no files.

I still think the patch is the right thing to do. Should I resend this and
the previous patch with these small changes to the commit messages?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20141103/b88a9080/attachment.html>


More information about the Mercurial-devel mailing list