[PATCH 2 of 5] test-revert: don't unnecessarily pipe through 'cat'

[Martin von Zweigbergk]

Oh! It never even hit me that it was about the command. Thanks for
explaining. I don't think I'll bother changing it, but I'm glad I know what
the issue was about.

On Mon, Nov 3, 2014, 06:53 Mads Kiilerich <mads at kiilerich.com> wrote:

> On 11/03/2014 02:20 PM, Pierre-Yves David wrote:
> >
> >
> > On 11/02/2014 11:05 PM, Martin von Zweigbergk wrote:
> >>
> >>
> >> On Sun Nov 02 2014 at 2:45:40 PM Pierre-Yves David
> >> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org
> >>
> >> wrote:
> >>
> >>
> >>
> >>     On 11/02/2014 10:19 PM, Martin von Zweigbergk wrote:
> >>      > # HG changeset patch
> >>      > # User Martin von Zweigbergk <martinvonz at google.com
> >>     <mailto:martinvonz at google.com>>
> >>      > # Date 1413682221 25200
> >>      > #      Sat Oct 18 18:30:21 2014 -0700
> >>      > # Branch stable
> >>      > # Node ID 9439327a222474b6af32ed9f717bfc__e81f90e53b
> >>      > # Parent  5df55ad6918a76870695dfe8551683__09bb5da27c
> >>      > test-revert: don't unnecessarily pipe through 'cat'
> >>      >
> >>      > diff --git a/tests/test-revert.t b/tests/test-revert.t
> >>      > --- a/tests/test-revert.t
> >>      > +++ b/tests/test-revert.t
> >>      > @@ -730,7 +730,7 @@
> >>      >
> >>      >   Setup working directory
> >>      >
> >>      > -  $ python ../gen-revert-cases.py wc | cat
> >>      > +  $ python ../gen-revert-cases.py wc
> >>      >     $ hg addremove --similarity 0
> >>      >     removing added_removed
> >>      >     removing added_revert
> >>
> >>
> >>     check-code says hi:
> >>
> >>          Skipping mercurial/httpclient/__socketutil.py it has
> >>     no-che?k-code (glob)
> >>     +  tests/test-revert.t:733:
> >>     +   >   $ python ../gen-revert-cases.py wc
> >>     +   filter wc output
> >>     +  [1]
> >>
> >>
> >> Oops, sorry about that. What's the purpose of it? The check was in the
> >> first version of check-code, so I couldn't find any explanation for it
> >> in the changelog.
> >
> > I don't known why it is here. We should probably ask Matt about it
> > (cced him)
>
> IIRC, the output of wc varies across platforms.
>
> In this case you could use another name than wc or change the check to
> look for something like   (^|\|\s*)\bwc\b
>
> /Mads
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20141103/2a24c4cc/attachment.html>