[PATCH 2 of 4] largefiles: remove confusing 'or None' from predicate

Martin von Zweigbergk martinvonz at google.com
Mon Nov 3 10:40:53 CST 2014


On Mon Nov 03 2014 at 8:11:50 AM Mads Kiilerich <mads at kiilerich.com> wrote:

> On 11/03/2014 02:40 AM, Martin von Zweigbergk wrote:
> > I don't think matchfn is ever set to None anywhere else (and I have
> > been staring at matcher code for the last week), so that's probably
> > not the reason.
>
> We have some occurences of 'matchfn = None' and we have several boolean
> checks on matchfns. But I doubt it makes any difference here.
>

I suspect all those cases are the _matcher_ being checked or assigned to.
I.e, we may have "matchfn = None" and "if matchfn", but not "match.matchfn
= None" nor "if match.matchfn" (the "matchfn" you are referring to should
probably be called "match[er]").
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20141103/f85e9f91/attachment.html>


More information about the Mercurial-devel mailing list