[PATCH 1 of 7] context.status: remove overriding in workingctx

Martin von Zweigbergk martinvonz at google.com
Tue Nov 4 18:51:17 CST 2014


Great. Thanks for reviewing, Sean.

On Tue Nov 04 2014 at 4:47:39 PM Sean Farley <sean.michael.farley at gmail.com>
wrote:

>
> Pierre-Yves David writes:
>
> > On 11/05/2014 12:31 AM, Sean Farley wrote:
> >>
> >> Sean Farley writes:
> >>
> >>> Martin von Zweigbergk writes:
> >>>
> >>>> # HG changeset patch
> >>>> # User Martin von Zweigbergk <martinvonz at google.com>
> >>>> # Date 1414097000 25200
> >>>> #      Thu Oct 23 13:43:20 2014 -0700
> >>>> # Branch stable
> >>>> # Node ID d68ec9fdce58cb01ec349e2731cf09247b10f436
> >>>> # Parent  cc1cbb0bba8ed1d95c8f1b8e27d4d2893e0dcca7
> >>>> context.status: remove overriding in workingctx
> >>>
> >>> Overall, I strongly think this series is moving in the wrong
> >>> direction.
> >>
> >> After some IRC discussion, I took the time to test some of my memctx WIP
> >> with these changes and it's not as bad as I initially worried. This
> >> patch series cleans up some (arguably over-designed) parts of status
> >> that I'm ok with dropping.
> >
> > Does this mean the whole series looks good to you as is? Or is a V2
> > still to be expected?
>
> The series does look good. I was just over-worrying with the design of
> pre/post status. I can live with just overriding _buildstatus.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20141105/b0a78225/attachment.html>


More information about the Mercurial-devel mailing list