[PATCH 2 of 2] win32: remove Mercurial.ini file from Inno Setup installer (issue4435)

Mads Kiilerich mads at kiilerich.com
Tue Nov 4 19:16:46 CST 2014


On 11/04/2014 10:43 PM, Pascal Quantin wrote:
> # HG changeset patch
> # User Pascal Quantin <pascal.quantin at gmail.com>
> # Date 1415134467 -3600
> #      Tue Nov 04 21:54:27 2014 +0100
> # Node ID 871aea23211152e39fb9b145e530ae5ab4886e21
> # Parent  b792b22f8d3bf362c3a5c694b57214154463b8a8
> win32: remove Mercurial.ini file from Inno Setup installer (issue4435)

Thanks for fixing my blind and bad changes.

> diff --git a/contrib/win32/mercurial.iss b/contrib/win32/mercurial.iss
> --- a/contrib/win32/mercurial.iss
> +++ b/contrib/win32/mercurial.iss
> @@ -67,7 +67,6 @@
>   Source: contrib\hgweb.fcgi; DestDir: {app}/Contrib
>   Source: contrib\hgweb.wsgi; DestDir: {app}/Contrib
>   Source: contrib\win32\ReadMe.html; DestDir: {app}; Flags: isreadme
> -Source: contrib\win32\mercurial.ini; DestDir: {app}; DestName: Mercurial.ini; Check: CheckFile;

Should we really just stop installing contrib/win32/mercurial.ini ? If 
so, shouldn't the file be removed?

 From the "Do Not Edit This File" I would assume that it would be a good 
fit for installation in default.d . But from the actual (no) content of 
this file, it seems like it would be fine to install it as before but 
_never_ overwrite it on upgrades.

/Mads



More information about the Mercurial-devel mailing list