[PATCH 5 of 5] changelog: rely on transaction for finalization

[Matt Mackall]

On Thu, 2014-11-06 at 00:41 +0000, Pierre-Yves David wrote:
> 
> On 11/06/2014 12:28 AM, Matt Mackall wrote:
> > On Sun, 2014-11-02 at 14:20 +0000, Pierre-Yves David wrote:
> >> # HG changeset patch
> >> # User Pierre-Yves David <pierre-yves.david at fb.com>
> >> # Date 1413619781 25200
> >> #      Sat Oct 18 01:09:41 2014 -0700
> >> # Node ID 3270e2ef0b7d74003e49fcdec588763c258a1038
> >> # Parent  d434fffe10dac3cb137b3695426a69a4cef9ef35
> >> changelog: rely on transaction for finalization
> >
> > I've queued the first four patches here, thanks. But I can't work out by
> > inspection why the weakref is essential, so it needs inline
> > justification. We'd really prefer to avoid the weakref if at all
> > possible, of course.
> 
> TL;DR: the weakref is nothing new, just code movement.

Right, spotted over in localrepo.py where it's similarly mysterious. And
I see you already explained this to Greg. Ok, queued.

-- 
Mathematics is the supreme nostalgia of our time.