[PATCH STABLE 🚑] mail: actually use the verifycert config value

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Nov 6 03:32:02 CST 2014



On 11/06/2014 05:19 AM, Martin von Zweigbergk wrote:
>
>
> On Wed Nov 05 2014 at 5:11:57 PM Pierre-Yves David
> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
> wrote:
>
>     # HG changeset patch
>     # User Pierre-Yves David <pierre-yves.david at fb.com
>     <mailto:pierre-yves.david at fb.com>>
>     # Date 1415212299 0
>     #      Wed Nov 05 18:31:39 2014 +0000
>     # Node ID 3a44dbed6cb41b9573b4d74dd4cd99__98a8f6a1c2
>     # Parent  1743ad376a1aae9981a8fdd57f3690__e8a8c0d819
>     mail: actually use the verifycert config value
>
>     The mail module only verify the smtp ssl certificate if 'verifycert'
>     is enabled
>     (the default). The 'verifycert' can take three possible values:
>
>     - 'strict' (means enabled)
>     - 'loose' (means disabled)
>
>
> According to the commit message of the commit that added the feature
> (http://selenic.com/hg/rev/19d489404d79), 'loose' does not mean
> disabled. The differentiation between 'loose' and 'strict' seems to be
> done here: http://selenic.com/hg/file/2d54aa5397cd/mercurial/mail.py#l133

Good catch! the brokeness is apparently only in the "False" value. 
sending a V2.


-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list