[PATCH help-search] hgweb: add help searching

[Augie Fackler]

On Nov 6, 2014, at 3:00 PM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:

> 
> 
> On 11/06/2014 07:58 PM, Augie Fackler wrote:
>> 
>> On Nov 6, 2014, at 2:56 PM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>> 
>>> 
>>> 
>>> On 11/06/2014 07:55 PM, Augie Fackler wrote:
>>>> # HG changeset patch
>>>> # User Augie Fackler <raf at durin42.com>
>>>> # Date 1409079849 14400
>>>> #      Tue Aug 26 15:04:09 2014 -0400
>>>> # Node ID dab7a85b5749d51fbaf426ffe4a405d6b718da91
>>>> # Parent  3a197c6997e223db6454af5937d912b008a8604f
>>>> hgweb: add help searching
>>>> 
>>>> I'm not sure the UI on this is reasonable - right now I add another
>>>> search box in the lower-right corner of the screen. I think it might
>>>> be better to have the existing search box search help when we're in a
>>>> help context, and search changesets otherwise. Thoughts?
>>> 
>>> "Search "babar" in Mercurial manual" link in the search result page?
>> 
>> I dunno. That means searching help takes two actions, which seems like a bummer.
> 
> I'm more offering this idea and a way to make the feature discoverable. I think the search help in help context is a good idea.

Okay. I'll see about making that change (when in a help context, search searches help) and will do a resend. I'll also see about adding the "search help for X" link on the normal SERP. Thanks!

> I could add a radio button for changes/help to toggle what the current box is for, and use js to make it go the right place. Clients without js would just not get help searching...
> 
> I'm afraid this would add too much confusion/ugliness in the UI for low added value.

Agreed.

> 
> -- 
> Pierre-Yves David