[PATCH 3 of 7] context.status: move manifest caching trick to _buildstatus()

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Nov 11 04:15:29 CST 2014



On 11/11/2014 12:49 AM, Martin von Zweigbergk wrote:
> On Mon Nov 10 2014 at 4:45:00 PM Pierre-Yves David
> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
> wrote:
>
>
>
>     On 11/11/2014 12:38 AM, Martin von Zweigbergk wrote:
>      > Sounds good to me. I think you're the one who picked up this
>     series. Do
>      > you want me to resend?
>
>     Did not follow the whole matt feedback yet. do you need to do some
>     actual code change or is the comment the only changed need. If comment
>     only, it can be a follow up.
>
>
> No real code change needed, but adding Matt's explanation where it
> currently says "load earliest manifest first for caching reasons" would
> be nice. But never mind, that's probably better done in a separate patch
> on top of these other ones anyway. I'll try to remember to send such a
> patch once this series is in.

Yes, it can go in a separated patch. If you send it now, I'll put it on 
top of the other.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list