[PATCH 2 of 2] revlog: add Mercurial config variable for limiting delta-chain length

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Nov 11 09:20:57 CST 2014



On 11/11/2014 03:03 PM, Augie Fackler wrote:
> On Tue, Nov 11, 2014 at 9:57 AM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>>>>
>>>> We do not have a 'revlog' section yet. I would use the 'format' one for
>>>> this
>>>> as this is kind of related to the on disk format.
>>>
>>>
>>>
>>> format sounds good. Can I get you to send me a followup once I push?
>>
>>
>> Meh, I do not see any value for using a followup there.
>
> But then the patch I'm pushing doesn't match the behavioral intent of
> what Mateusz sent, which starts making me a little weird about
> "signing his name" on the modified patch. I think a followup here is
> more appropriate.
>
> (I'm fine fixing up wording things for you in-flight because you've
> asked me to, and I'm fine fixing minor test failure problems for
> anyone because the intent is always clear. This, to me, seems over the
> line of what I'm willing to just ninja-fix for someone.)

+1 I was meaning dropping the patch and asking for a followup. Behavior 
change or significant refactor should not be fixed in flight.


-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list