[PATCH stable] addremove: add back forgotten files
Martin von Zweigbergk
martinvonz at google.com
Tue Nov 11 11:29:16 CST 2014
On Tue Nov 11 2014 at 9:17:55 AM Augie Fackler <raf at durin42.com> wrote:
> On Tue, Nov 11, 2014 at 12:16 PM, Martin von Zweigbergk
> <martinvonz at google.com> wrote:
> >> > # Node ID abe330fc28e4b612e0ed2be5fc3cdaa378396ddd
> >> > # Parent 2d54aa5397cdb1c697673ba10b7618d5ac25c69e
> >> > addremove: add back forgotten files
> >> I've dithered on this, but it also seems reasonable. Does this go
> >> hand-in-hand with your add patch that you sent yesterday?
> > I didn't know I was going to write the other patch when I wrote this one,
> > but it seems clear to me that the other one is correct. Regardless of
> > other patch, it does seem like "hg add $file" and "hg addremove $file"
> > should behave the same if the file exists on disk. It also seems like the
> > point of 'hg addremove [.]' is to make "hg commit" not leave files
> > Should I resend with a bit more of this thinking in the description?
> Yes, I think that would help your reviewers immensely. Maybe send both
> patches as a series of 2?
Sounds good. Will do.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mercurial-devel