[PATCH 2 of 2] revlog: add Mercurial config variable for limiting delta-chain length

Mateusz Kwapich mitrandir at fb.com
Tue Nov 11 12:57:25 CST 2014


I totally fine with this cleanup. Thanks for fast review! :)

On 11/11/14, 9:31 AM, "Augie Fackler" <raf at durin42.com> wrote:

>On Tue, Nov 11, 2014 at 10:20 AM, Pierre-Yves David
><pierre-yves.david at ens-lyon.org> wrote:
>>
>>
>> On 11/11/2014 03:03 PM, Augie Fackler wrote:
>>>
>>> On Tue, Nov 11, 2014 at 9:57 AM, Pierre-Yves David
>>> <pierre-yves.david at ens-lyon.org> wrote:
>>>>>>
>>>>>>
>>>>>> We do not have a 'revlog' section yet. I would use the 'format' one
>>>>>>for
>>>>>> this
>>>>>> as this is kind of related to the on disk format.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> format sounds good. Can I get you to send me a followup once I push?
>>>>
>>>>
>>>>
>>>> Meh, I do not see any value for using a followup there.
>>>
>>>
>>> But then the patch I'm pushing doesn't match the behavioral intent of
>>> what Mateusz sent, which starts making me a little weird about
>>> "signing his name" on the modified patch. I think a followup here is
>>> more appropriate.
>>>
>>> (I'm fine fixing up wording things for you in-flight because you've
>>> asked me to, and I'm fine fixing minor test failure problems for
>>> anyone because the intent is always clear. This, to me, seems over the
>>> line of what I'm willing to just ninja-fix for someone.)
>>
>>
>> +1 I was meaning dropping the patch and asking for a followup. Behavior
>> change or significant refactor should not be fixed in flight.
>
>
>FYI, I pushed a cleanup to crew for this:
>https://urldefense.proofpoint.com/v1/url?u=http://hg.intevation.org/mercur
>ial/crew/rev/8d1c508181e6&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=bEOykPJz1n0%
>2F%2B%2BVnnlfR9Q%3D%3D%0A&m=EzUAL2%2Bgyf5mvi4y5srzo3Ou7%2Fagq%2F8h5gPfQ0%2
>BqoDo%3D%0A&s=04e340ef490873e5b24b4968045fffd5db944be2eb3ba632304da713d71c
>8d52



More information about the Mercurial-devel mailing list