[PATCH STABLE] largefiles: avoid exec-bit examination on the platform being unaware of it

[Matt Mackall]

On Mon, 2014-11-24 at 23:21 +0900, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1416838654 -32400
> #      Mon Nov 24 23:17:34 2014 +0900
> # Branch stable
> # Node ID d47e371f9abe39460340b77738b672001841b054
> # Parent  cc0ff93d0c0c29526465a1d07b9eddf5b2da51dd
> largefiles: avoid exec-bit examination on the platform being unaware of it
> 
> Changeset 24600c9d7f4e introduced the examination of exec bit of
> largefiles in "hg status --rev REV" case, but it doesn't avoid it on
> the platform being unaware of exec-bit (e.g. on NTFS of Windows).
> 
> To avoid leak of internal implementation of "dirstate" class, this
> patch uses "util.checkexec" instead of "dirstate._checkexec", even
> though the former costs (a little) more than the latter when the
> latter is already cached. This kind of information may have to be
> cached at VFS layer in the future.

I think it's ok to use dirstate._checkexec here. The underscore is
advisory: think of it as like C++'s "friend" rather than "private".

-- 
Mathematics is the supreme nostalgia of our time.