[PATCH 6 of 8] dirstate: create class for status lists

[Martin von Zweigbergk]

On Wed, Oct 1, 2014 at 6:40 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
>
> On 10/02/2014 02:01 AM, Martin von Zweigbergk wrote:
>>
>>   @@ -2511,19 +2511,19 @@
>>                                     unknown=True, ignored=True,
>> clean=True)
>>           else:
>>               changes = repo.status(match=m)
>> -            for kind in changes:
>> +            for kind in changes.all():
>>                   for abs in kind:
>>                       names[abs] = m.rel(abs), m.exact(abs)
>>                 m = scmutil.matchfiles(repo, names)
>>   -        modified = set(changes[0])
>> -        added    = set(changes[1])
>> -        removed  = set(changes[2])
>> -        _deleted = set(changes[3])
>> -        unknown  = set(changes[4])
>> -        unknown.update(changes[5])
>> -        clean    = set(changes[6])
>> +        modified = set(changes.modified)
>> +        added    = set(changes.added)
>> +        removed  = set(changes.removed)
>> +        _deleted = set(changes.deleted)
>
>
> Instead of refactoring an unused line,

Are you referring to '_deleted'? Why do you think it's unused? Because
it starts with underscore? I didn't see anything about that in the
style guide, but I think I've seen that convention in some places.
Should I send a patch?

> it would be nice to just remove it in
> an earlier changeset.

Off topic, but that reminds me: I hope someone is working on the
'stop/halt' action for histedit so that's not such a pain. (But please
correct me if there's something better than "hg bookmark -r .^^^ tmp
&& hg update tmp && <edit> && hg commit && hg update feature && hg
rebase -d tmp && hg bookmarks -d tmp". I'd prefer something like "hg
histedit && <edit> && hg commit && hg histedit --continue".)