[PATCH 3 of 8] localrepo: ignore always-empty 'unknown' files when looking for '.hgtags'

Martin von Zweigbergk martinvonz at gmail.com
Thu Oct 2 18:54:57 CDT 2014

On Thu, Oct 2, 2014 at 4:41 PM, Matt Mackall <mpm at selenic.com> wrote:
> On Wed, 2014-10-01 at 17:01 -0700, Martin von Zweigbergk wrote:
>> # HG changeset patch
>> # User Martin von Zweigbergk <martinvonz at gmail.com>
>> # Date 1412196063 25200
>> #      Wed Oct 01 13:41:03 2014 -0700
>> # Node ID e1154b545f8411371124e7c24fd7e3f67c11dcba
>> # Parent  82b9c894095a9d739c25c42951ed1c7788b5ad90
>> localrepo: ignore always-empty 'unknown' files when looking for '.hgtags'
>> Since the call to self.status() does not request listing of unknown
>> files, that list will always be empty. Still, the lists of files
>> searched for '.hgtags' includes that list, but not the ignored and
>> clean files, which will also always be empty. This seems misleading,
>> so let's ignore the unknown files as well.
> The semantics here changed as a side effect when I changed the default
> args to status in 2008:
> http://www.selenic.com/hg/diff/4faaa0535ea7/mercurial/localrepo.py
> ..but I don't think your suggested change is actually correct: if we
> have a non-tracked .hgtags, we don't want to blindly append to it and
> commit it because we'll be introducing more that our tag in the commit.

Ah, I see. That makes sense.

> I'll clean this up.


More information about the Mercurial-devel mailing list